Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support stable rustc (again) #7039

Closed
kdy1 opened this issue Mar 9, 2023 · 6 comments · Fixed by #7057
Closed

Support stable rustc (again) #7039

kdy1 opened this issue Mar 9, 2023 · 6 comments · Fixed by #7057
Assignees
Milestone

Comments

@kdy1
Copy link
Member

kdy1 commented Mar 9, 2023

Describe the feature

I used box_patterns while working on #7041 because refactoring for box_patterns is much bigger than the PR itself, and I wanted to align the version of swc_core between projects in a short time.

But we should support stable rustc.

@stevefan1999-personal
Copy link

Let's open it back shall we, look at the issues I mentioned

@kdy1
Copy link
Member Author

kdy1 commented Apr 9, 2023

@stevefan1999-personal Please list the crate you are trying to use. This issue is closed because crates I want to support stable rustc are all fixed

@ije

This comment has been minimized.

@ije

This comment has been minimized.

@swc-project swc-project temporarily blocked ije Apr 20, 2023
@MolotovCherry
Copy link

MolotovCherry commented May 4, 2023

swc_ecma_minifier is also blocking me from compiling on stable.

For anyone who reads this, using swc_ecma_minifier version 0.172.0 will fix it, but unfortunately this will carry the cost of no fixes/improvements since then (might also have to downgrade a few more packages to get the versions to match up as well)

(I'd also like to use swc_html_minifier, but it looks like I'll have to downgrade that one as well)

@swc-bot
Copy link
Collaborator

swc-bot commented Jun 4, 2023

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@swc-project swc-project locked as resolved and limited conversation to collaborators Jun 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging a pull request may close this issue.

5 participants