fix(ci): insert *_bg files in @swc/wasm-web (#1291) #1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described by #1291, right now
@swc/wasm-webcannot be used after installation because@swc/wasm-webdoes not include files that wasm-bindgen produces when it gets published.This happens due to a bug in wasm-pack (rustwasm/wasm-pack#837).
Therefore, the simplest solution would just be including the
filesmanually inpackage.jsonbefore publishing.Initially I thought the only file that needs to be included would be
wasm_bg.js, butwasm_bg.wasm.d.tscomes along with the build output too, so there's no reason not to include it as a part of API.This would allow #50 to get going too.
Would close #1291 if it gets merged
cc @kdy1