Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat(es): Support typeof with private fields (#4302)" #4542

Merged

Conversation

williamtetlow
Copy link
Contributor

Description:
Context:#4302 (comment)

Typescript compiler has reverted microsoft/TypeScript#47696 in microsoft/TypeScript#48959 so we should revert support until then.

BREAKING CHANGE:

Related issue (if exists):

@williamtetlow williamtetlow marked this pull request as ready for review May 5, 2022 18:26
@williamtetlow
Copy link
Contributor Author

@dsherret also fyi 😄

@kdy1 kdy1 added this to the Planned milestone May 6, 2022
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!


swc-bump:

  • swc_ecma_ast --breaking

@kdy1 kdy1 enabled auto-merge (squash) May 6, 2022 03:48
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit e2fde1a into swc-project:main May 6, 2022
@kdy1 kdy1 modified the milestones: Planned, v1.2.178 May 7, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants