Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(es/minifier): new Array #4932

Merged
merged 6 commits into from
Jun 11, 2022
Merged

feat(es/minifier): new Array #4932

merged 6 commits into from
Jun 11, 2022

Conversation

magic-akari
Copy link
Member

Description:

BREAKING CHANGE:

Related issue (if exists):

@kdy1 kdy1 added this to the Planned milestone Jun 10, 2022
@magic-akari magic-akari marked this pull request as draft June 10, 2022 16:27
@magic-akari magic-akari marked this pull request as ready for review June 11, 2022 01:44
Austaras
Austaras reviewed Jun 11, 2022
View reviewed changes
crates/swc_ecma_minifier/src/compress/pure/misc.rs
// https://262.ecma-international.org/12.0/#sec-error-constructor
"Error",
// https://262.ecma-international.org/12.0/#sec-aggregate-error-constructor
"AggregateError",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Object too

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And native errors

kdy1
kdy1 approved these changes Jun 11, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

swc-bump:

  • swc_ecma_utils
  • swc_ecma_minifier

@kdy1 kdy1 enabled auto-merge (squash) June 11, 2022 05:03
swc-bot
swc-bot reviewed Jun 11, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 5940894 into swc-project:main Jun 11, 2022
@kdy1 kdy1 modified the milestones: Planned, v1.2.199 Jun 11, 2022
@magic-akari magic-akari deleted the feat/minify/array branch June 30, 2022 12:10
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ArturAralin ArturAralin ArturAralin left review comments

@Austaras Austaras Austaras left review comments

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.2.199
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@magic-akari @ArturAralin @Austaras @kdy1 @swc-bot