Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Fix optimization of template literals with escape #5650

Merged
merged 4 commits into from
Aug 28, 2022
Merged

fix(es/minifier): Fix optimization of template literals with escape #5650

merged 4 commits into from
Aug 28, 2022
+672,972 −1

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Aug 28, 2022 •
edited
Loading

Description:

A template string literal is wrongly optimized if it has an escape.

Related issue (if exists):

@kdy1 kdy1 added this to the Planned milestone Aug 28, 2022
kdy1
kdy1 commented Aug 28, 2022
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_minifier

@kdy1 kdy1 marked this pull request as ready for review August 28, 2022 02:44
kodiakhq[bot]
kodiakhq bot previously approved these changes Aug 28, 2022
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) August 28, 2022 02:44
@kdy1 kdy1 merged commit 100f359 into swc-project:main Aug 28, 2022
@kdy1 kdy1 deleted the minifier-next branch August 28, 2022 03:15
@kdy1 kdy1 modified the milestones: Planned, v1.2.245 Aug 30, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.2.245
Development

Successfully merging this pull request may close these issues.
1 participant
@kdy1