fix(es/minifier): Abort IIFE invoker on eval
#6478
Merged
+1,442
−1,353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdy1
changed the title
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
jridgewell
reviewed
Dec 8, 2022
| @@ -728,6 +728,13 @@ where | |||
| } | |||
| } | |||
|
|
|||
| // If we has an eval, we cannot remap variables correctly. | |||
| let has_eval = contains_eval(body, false); | |||
| if !param_ids.is_empty() && has_eval { | |||
There was a problem hiding this comment.
I'm kinda surprised we allow any further modifications in the presence of eval.
There was a problem hiding this comment.
eval is used by some libraries, so I thought we should only give up if it's going to be problematic. (e.g. name mangler aborts)
There was a problem hiding this comment.
But I'm not sure about this. Do you think it's better to abort completely on eval?
There was a problem hiding this comment.
Personally, yah, I would. Looking at terser, eval deopts:
- name mangling
- unused var removal
- joining of expressions
- inlining functions
- conversion from functions/methods to arrows
There was a problem hiding this comment.
Did it and checked other passes, too. Thank you!
jridgewell
approved these changes
Dec 12, 2022
swc-bot
reviewed
Dec 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue:
Investigation
This is an issue of
invoke_iife. I used patch script to check each function.There are two variables named
exports