Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support accessor method and property #7046

Merged
merged 3 commits into from
Mar 10, 2023
Merged

fix: support accessor method and property #7046

merged 3 commits into from
Mar 10, 2023

Conversation

suxin2017
Copy link
Contributor

@suxin2017 suxin2017 commented Mar 10, 2023 •
edited by kdy1
Loading

Description:
fix issue-7042

Related issue:

@suxin2017
Copy link
Contributor Author

I will add the test case later

@suxin2017 suxin2017 changed the title feat: support accessor method and property fit: support accessor method and property Mar 10, 2023
@kdy1 kdy1 self-assigned this Mar 10, 2023
@suxin2017 suxin2017 changed the title fit: support accessor method and property fix: support accessor method and property Mar 10, 2023
@suxin2017 suxin2017 marked this pull request as ready for review March 10, 2023 05:44
@kdy1 kdy1 added this to the Planned milestone Mar 10, 2023
kdy1
kdy1 approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

swc-bump:

  • swc_ecma_parser

@kdy1 kdy1 enabled auto-merge (squash) March 10, 2023 05:54
@zhangqingcong
Copy link

nine brother new bee

@kdy1 kdy1 merged commit 9acaf4d into swc-project:main Mar 10, 2023
@kdy1 kdy1 modified the milestones: Planned, v1.3.40 Mar 13, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.40
Development

Successfully merging this pull request may close these issues.

Using accessor as class method results in incorrect code.
3 participants
@suxin2017 @zhangqingcong @kdy1