Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(es/ast): Avoid transmute in impl of Hash for Number #7771

Merged
merged 2 commits into from
Aug 7, 2023
Merged

refactor(es/ast): Avoid transmute in impl of Hash for Number #7771

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6fe732
Use f64::to_bits() instead of transmute in hash impl
Manishearth Aug 7, 2023
a66d96c
Merge branch 'main' into tobits
Manishearth Aug 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions crates/swc_ecma_ast/src/lit.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ use std::{
borrow::Cow,
fmt::{self, Display, Formatter},
hash::{Hash, Hasher},
mem,
};

use num_bigint::BigInt as BigIntValue;
Expand Down Expand Up @@ -353,7 +352,7 @@ impl EqIgnoreSpan for Number {
impl Hash for Number {
fn hash<H: Hasher>(&self, state: &mut H) {
fn integer_decode(val: f64) -> (u64, i16, i8) {
let bits: u64 = unsafe { mem::transmute(val) };
let bits: u64 = val.to_bits();
let sign: i8 = if bits >> 63 == 0 { 1 } else { -1 };
let mut exponent: i16 = ((bits >> 52) & 0x7ff) as i16;
let mantissa = if exponent == 0 {
Expand Down
Loading