Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/module): Read link if an import is resolved as symlink #8297

Merged
merged 24 commits into from
Nov 20, 2023
Merged

fix(es/module): Read link if an import is resolved as symlink #8297

merged 24 commits into from
Nov 20, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Nov 16, 2023

Description:

Related issue:

@kdy1 kdy1 added this to the Planned milestone Nov 16, 2023
@kdy1 kdy1 self-assigned this Nov 16, 2023
@kdy1 kdy1 changed the title fix(es/modules): Fix regression of symlinks fix(es/modules): Read link if an import is resolved as symlink Nov 16, 2023
kdy1
kdy1 commented Nov 16, 2023
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_transforms_module

@kdy1 kdy1 marked this pull request as ready for review November 16, 2023 03:21
@kdy1 kdy1 requested review from a team as code owners November 16, 2023 03:21
@kdy1 kdy1 changed the title fix(es/modules): Read link if an import is resolved as symlink fix(es/module): Read link if an import is resolved as symlink Nov 16, 2023
@kdy1 kdy1 enabled auto-merge (squash) November 20, 2023 04:32
swc-bot
swc-bot reviewed Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

swc-bot
swc-bot reviewed Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

swc-bot
swc-bot reviewed Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 disabled auto-merge November 20, 2023 22:16
@kdy1 kdy1 merged commit 7dfdc12 into swc-project:main Nov 20, 2023
141 checks passed
@kdy1 kdy1 deleted the issue-8139 branch November 20, 2023 22:17
@kdy1 kdy1 modified the milestones: Planned, v1.3.98 Nov 21, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.99
Development

Successfully merging this pull request may close these issues.

jsc.paths regression in 1.3.79
2 participants
@kdy1 @swc-bot