refactor(es/ast): Remove unused fields of TsPropertySignature
#8955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lucacasonato
force-pushed
the
remove_unused_fields
branch
from
2d4f3e9
to
ac2fe73
Compare
|
I suggest you review the two commits independently. The second one is just test expectation updates caused by the first commit. All code changes are in the first commit. |
kdy1
previously approved these changes
May 20, 2024
- TsPropertySignature can not have params, type params, or an initializer. - TsGetterSignature can not be optional or readonly. - TsSetterSignature can not be optional or readonly. - TsMethodSignature can not be readonly.
kdy1
force-pushed
the
remove_unused_fields
branch
from
be61f2e
to
d6bc36a
Compare
kdy1
changed the title
TsPropertySignature
kdy1
approved these changes
Jun 14, 2024
kdy1
changed the title
TsPropertySignatureTsPropertySignature
swc-bot
reviewed
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
TsPropertySignature can not have params, type params, or an initializer.
BREAKING CHANGE:
Yes. Any users looking into these fields should stop - they are always empty.