Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add online REPL page #42

Merged
merged 4 commits into from
Jul 1, 2021
Merged

Add online REPL page #42

merged 4 commits into from
Jul 1, 2021

Conversation

9oelM
Copy link
Contributor

@9oelM 9oelM commented Jun 29, 2021

Kapture.2021-06-30.at.00.08.19.mp4

This PR adds the long-awaited online REPL on swc's website. Because it's the first one, it just adds the most basic functionality of REPL: compiling the code and showing the output. Nothing really more.

Partly because the website is based on Docusaurus, there are more things to configure right now. For the next commits, following things are expected to be done:

  • inserting various options in transpiling
  • enlarging the editor (now it's too small because of Docusaurus' default layout)
  • running wasm in a separate worker thread
  • anything else you'd like

Will close #6 and swc-project/swc#50

@9oelM
Copy link
Contributor Author

9oelM commented Jun 29, 2021

cc @kdy1

@kdy1
Copy link
Member

kdy1 commented Jun 30, 2021

Wow, cool!
Thank you!

Is this PR done? (I'm asking this because of WIP in the title)

@9oelM
Copy link
Contributor Author

9oelM commented Jun 30, 2021

I wasn't too sure if I should append more commits to improve the current PR, so I just marked this PR as draft. It's fine if you want to merge this PR first, and then let me add more commits to improve it.

I'm also not sure if it's going to be successfully built and deployed because i made upgraded/added some dependencies and there is no CI preview to check if the build does not fail. But when things break, we can always fix them by then too. haha

@9oelM 9oelM marked this pull request as ready for review June 30, 2021 02:31
@9oelM 9oelM changed the title (WIP) Add online REPL page Add online REPL page Jun 30, 2021
@9oelM
Copy link
Contributor Author

9oelM commented Jul 1, 2021

@kdy1 then.. let's merge it first?

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LHTM. Thanks!

@kdy1 kdy1 merged commit 917f5f7 into swc-project:master Jul 1, 2021
@9oelM 9oelM mentioned this pull request Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

REPL / playground
2 participants