Skip to content
This repository has been archived by the owner on Jan 3, 2018. It is now read-only.

Some minor edits to the loops lesson #896

Closed
wants to merge 6 commits into from

Conversation

chinchliff
Copy link

I added a challenge problem that introduces while loops--these don't seem to be critical to the lesson material but they are an important element of programming and it seems useful to at least mention them here. I also reworded some of the explanation/discussion of mutable vs. immutable variables, in an effort to improve clarity. Finally, I made a couple of other (very minor) changes to some examples.

@rgaiacs
Copy link

rgaiacs commented Nov 24, 2014

@chinchliff Thanks for this. The file novice/python/03-loop.md is generated using

$ make ipynb

Do you mind

  • Create a new feature branch
$ git remote add upstream git@github.com:swcarpentry/bc.git
$ git fetch upstream
$ git checkout upstream/gh-pages
$ git checkout -b improve-python-loop
  • Redo your changes from novice/python/03-loop.md at novice/python/03-loop.ipynb.
  • Run
$ make ipynb
  • Commit the new changes
$ git commit -a
  • Push the commits at the feature branch
$ git push origin improve-python-loop
  • Create a new pull request. Open https://github.com/swcarpentry/bc/ and GitHub will suggest you create a pull request. You just need to follow the instructions.
  • Close this pull request informing that it was replaced by your new pull request.

Why am I requesting this? (1) To you learn a little about branches, (2) to avoid the commit where you edit novice/python/03-loop.md by hand and (2) to avoid the various "minor formatting edit" commits. If you need any help just ask.

@gvwilson
Copy link
Contributor

Hi @chinchliff,

We can make this even easier - if you're willing to wait a couple of
days, you'll be able to make your change in Markdown only (no IPython
Notebook) in the new Python lesson repo - we're that close to merging
it. Please stay tuned... Or if you want to go ahead and merge here,
please do - we're happy to get content either way.

cheers,
Greg

@chinchliff
Copy link
Author

Hi Greg, Raniere,

I'm happy to wait a couple of days. If you could give me a heads up when
the new repo is ready I'll make a new pull request there with the changes.

On Monday, November 24, 2014, Greg Wilson notifications@github.com wrote:

Hi @chinchliff,

We can make this even easier - if you're willing to wait a couple of
days, you'll be able to make your change in Markdown only (no IPython
Notebook) in the new Python lesson repo - we're that close to merging
it. Please stay tuned... Or if you want to go ahead and merge here,
please do - we're happy to get content either way.

cheers,
Greg


Reply to this email directly or view it on GitHub
#896 (comment).

> Data that can be changed is called [mutable](../../gloss.html#mutable),
> while data that cannot be is called [immutable](../../gloss.html#immutable).
> Variables whose value can be changed after they have been created are called [mutable](../../gloss.html#mutable),
> while variables whose value cannot be changed are called [immutable](../../gloss.html#immutable).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good explanation, but be sure to also change the definition in the glossary for consistency.

@gvwilson gvwilson closed this Jul 30, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants