Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding labels to plot #1079

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

adding labels to plot #1079

wants to merge 1 commit into from

Conversation

jensbri
Copy link

@jensbri jensbri commented Apr 17, 2024

While I understand the beauty of having just 3 lines of code to ingest a dataset and output a heatmap, the resulting plot does not meet the basic requirements of an adequate plot. We shouldn't teach people to generate something 'data-sciency' that people can re-use without understanding what is to be seen on the plot.

If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.

If any relevant discussions have taken place elsewhere, please provide links to these.

For more guidance on how to contribute changes to a Carpentries project, please review the Contributing Guide and Code of Conduct.

Please keep in mind that lesson Maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at team@carpentries.org.

While I understand the beauty of having just 3 lines of code to ingest a dataset and output a heatmap, the resulting plot does not meet the basic requirements of an adequate plot. We shouldn't teach people to generate something 'data-sciency' that people can re-use without understanding what is to be seen on the plot.
Copy link

🆗 Pre-flight checks passed 😃

This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits.

It should be safe to Approve and Run the workflows that need maintainer approval.

Copy link
Member

@ineelhere ineelhere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your inputs. Please provide the output image too in order to reflect changes on the webpage. Thanks.

@jensbri
Copy link
Author

jensbri commented Apr 18, 2024

Kia ora.

Please find the output image below:
DataLabels

Copy link
Member

@ineelhere ineelhere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the screenshot, but this will not reflect on the tutorial content.

For the labels to show up on the image in the site, please also make changes to the file - episodes/fig/inflammation-01-imshow.svg in the .svg format and add changes to this same PR.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants