Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some code blocks in challenges miss {.sql} #34

Closed
pbanaszkiewicz opened this issue Feb 15, 2015 · 2 comments
Closed

Some code blocks in challenges miss {.sql} #34

pbanaszkiewicz opened this issue Feb 15, 2015 · 2 comments

Comments

@pbanaszkiewicz
Copy link
Member

Lessons 01, 03, 05 use SQL code block without defining a {.sql} class attribute.

@orchid00
Copy link
Contributor

+1 good list

@gvwilson
Copy link
Contributor

Closed by 06a6f74

zkamvar pushed a commit that referenced this issue May 8, 2023
Add validation methods and refactor ast helpers to separate class

Add tiny logging message; prep for first push to github fork

Start adding tests

Fix errors revealed by unit tests

Update validator to check heading order; tests passing

Validation of links and changes to heading validation

Tiny comment cleanup; push to share version with swc

Add some descriptive comments and create minimal validator example (for instructors.md) to demonstrate subclassing

Split helpers to separate file and update for newest index.md template

Grooming

Bring up to spec with newest versions of lesson templates. Add tests to ensure all templates pass validation.

Saner default assumption about markdown file locations

Add skeletons for remaining validators. Incorporate ranier's code for batch validation.

Code changes for single-file python 2 and 3 compatibility.

Refactor out template validation logic in prep for cmd line rework

Proof of concept refactor to command line sig for @rgaia-cs (issue #34)

With no path provided, default to curdir, not a hard-coded default

Implement license and discussion validators. Some test cleanup.

Validate file links against page titles. Add line length check.

Fix python3 hash error

Rename validator to check

Conflicts:
	tools/validate_markdown_template.py

Enforce section heading levels + pep8 cleanup

Improved link validation for non-html files

Validate images as well as links

Verify that all headings are exactly level 2

Link text validation based on document header "subtitle" instead of "title".

Adjustments based on run against the SQL repo.

Fix links to topics

By default only show erros and warnings to user

- Add another argument for CLI to enable debug log level
- Change some log message to debug instead of info
- Add file information for errors and warnings

Fix import at check

From [PEP8](https://www.python.org/dev/peps/pep-0008/#imports)

> Imports should usually be on separate lines, e.g.:
>
> Yes: import os
>      import sys
>
> No:  import sys, os

Heading bugfixes, update failing tests, and cleanup. fix swcarpentry/DEPRECATED-lesson-template#39, swcarpentry/DEPRECATED-lesson-template#42 .

Add validation of glossary

Slight clarification to log messages.

Skip validate some links in index

Fix super() call for python2; avoid mutable default argument.

Lesson template validator.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants