Allocate memory during instantiation, fixing segfaults in a few plugins #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allpass, comb and delay should also not set the buffer size based on the max_delay control, which is now deprecated.
|
Great, thank you very much! I will look into making a release soon. |
@swh that would be great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #8 and fixes #13 + segfaults when testing with lv2lint by moving memory allocation in affected plugins from activation to instantiation.
allpass, comb and delay should also not set the buffer size based on the
max_delaycontrol, which is now left as a dummy port. I guess the idea was to let users set the max buffer size as a means of manual memory optimization, but can cause issues (again, malloc during activation) and LV2 hosts usually don't let users set parameters upon instantiation.Also would be great to eventually have another stable release tagged, we're currently packaging this for Arch Linux with this patch applied :)
Thanks!