-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ABFFIO.DLL vs pyABF values #78
Comments
After more closely reviewing the header, I suspect that ABF1 files aren't selecting the proper https://github.com/swharden/pyABF/blob/master/data/headers/File_axon_3.md Compare what the header says to what ClampFit says:
Notice those numbers are 5 and 7, and that a scaling factor of 4 could explain the "400x" value. |
This probably only affects ABF1 files and is super low priority. I'll close it for now, and re-open it if this issue arises in the wild. |
previously nADCSamplingSeq was not being respected in ABF1 files, affecting offset and gain scaling of integer data when ADCs were not sequential. This fix fixes some long-running failing tests where first values of some files was different between ABFFIO.DLL and pyabf. #78 Tests pass now.
vsABF (which uses the official ABFFIO.DLL to read ABF values) just got far enough along that I was able to test it on all the ABFs in the data folder to compare their first values (for each channel) to those determined by pyABF. Sweep values produced by pyABF perfectly matched those produced by ABFFIO.DLL for every ABF file! ... with the exception of File_axon_3.abf (an ABF1 file). pyABF is reporting values for these two channels as exactly 100x and 400x larger than expected.
pyABF/tests/tests/valueChecks.py
Lines 23 to 84 in b4e2e58
The text was updated successfully, but these errors were encountered: