Updated YAML descriptions. #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 30, 2015
Merged
| Results of an attempted GPS signal acquisition. Contains the | ||
| parameters of the point in the acquisition search space with the | ||
| best signal-to-noise ratio. | ||
| This message describes the results from an attempted GPS signal |
There was a problem hiding this comment.
attempted => successful
There was a problem hiding this comment.
Attempted is correct. The message is sent even if the SNR is below the acceptable threshold. Should this be changed in the firmware?
|
Quick note here: the |
| # THIS CODE AND INFORMATION IS PROVIDED "AS IS" WITHOUT WARRANTY OF ANY KIND, | ||
| # EITHER EXPRESSED OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE IMPLIED | ||
| # WARRANTIES OF MERCHANTABILITY AND/OR FITNESS FOR A PARTICULAR PURPOSE. | ||
|
|
0. Clarifies and adds some field and message descriptions that were previously missing. 1. Adds short_desc messages where they were previously missing. 2. Refactors some messages in piksi.yaml into separate modules reflecting hierarchy in piksi_firmware. /cc @mfine @denniszollo @cbeighley
|
sgtc (sounds good to @cbeighley ). |
| Earth Centered Earth Fixed (ECEF) coordinates and the status | ||
| (single point absolute vs RTK) of the position solution. If the | ||
| rover receiver knows the single-point point position of the base | ||
| station and has an RTK solution, this reports a pseudo-absolute |
There was a problem hiding this comment.
This should say "Surveyed position of the base station". The user has to know an accurate position of the base station in order for the absolute RTK positions to be correspondingly accurate.
swiftnav-svc-jenkins
pushed a commit
that referenced
this pull request
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hierarchy in piksi_firmware.
Replaces #58 . Closes #45 .
TODO:
piksi.yamlmessage fields./cc @mfine @denniszollo @cbeighley @soulcmdc