New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code to be more inline with the Rust API style #65

Merged

jbangelo merged 1 commit into master from jbangelo/update-to-styleguide

Aug 1, 2021

Collaborator

jbangelo commented Aug 1, 2021 •

edited

Loading

As mentioned in #63 (comment) we have several inconsistencies in the function naming style and a few clippy warnings to clean up.

Remove get_ prefix on getter functions
Clean up some pattern matching logic per clippy advice
Make to_ conversion functions consume self to match common convention


          Update code to be more inline with the Rust API style

ff354e9

jbangelo requested review from notoriaga, jayvdb and silverjam

August 1, 2021 04:42

jayvdb approved these changes

View reviewed changes

silverjam approved these changes

View reviewed changes

notoriaga approved these changes

View reviewed changes

jbangelo merged commit d843a93 into master

jbangelo deleted the jbangelo/update-to-styleguide branch

August 1, 2021 22:16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet