Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close connection on DISCONNECT message #87

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Conversation

adam-fowler
Copy link
Collaborator

@adam-fowler adam-fowler commented Nov 4, 2021

Close connection after receiving DISCONNECT message from server
also fix reading of last buffer

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2021

Codecov Report

Merging #87 (33bffca) into main (ef331a6) will decrease coverage by 0.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
- Coverage   77.41%   77.15%   -0.27%     
==========================================
  Files          21       19       -2     
  Lines        2183     2092      -91     
==========================================
- Hits         1690     1614      -76     
+ Misses        493      478      -15     
Impacted Files Coverage Δ
...s/MQTTNIO/ChannelHandlers/MQTTMessageDecoder.swift 89.89% <100.00%> (+4.33%) ⬆️
Sources/MQTTNIO/MQTTListeners.swift 73.68% <0.00%> (-26.32%) ⬇️
Sources/MQTTNIO/MQTTClientV5.swift 62.92% <0.00%> (-15.74%) ⬇️
Sources/MQTTNIO/MQTTProperties.swift 76.47% <0.00%> (-1.69%) ⬇️
Sources/MQTTNIO/MQTTConnection.swift 91.07% <0.00%> (-1.20%) ⬇️
Sources/MQTTNIO/MQTTClient.swift 77.35% <0.00%> (-0.76%) ⬇️
...MQTTNIO/AsyncAwaitSupport/MQTTClientV5+async.swift
...s/MQTTNIO/AsyncAwaitSupport/MQTTClient+async.swift
Sources/MQTTNIO/MQTTPacket.swift 84.75% <0.00%> (+3.36%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef331a6...33bffca. Read the comment docs.

also fix reading of last buffer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants