Add `domainName` property to API Gateway V1 event #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

tomerd merged 3 commits into swift-server:main from Bunkyr:apigatewayV1-domainName

Sep 13, 2022

Contributor

MPLew-is commented Sep 13, 2022

Add support for the existing domainName property to API Gateway V1 events in Swift.

Motivation:

According to AWS example events and documentation, this seems to be included in all requests.
We should be able to access this seamlessly in Swift.

Modifications:

Added domainName property to requestContext in APIGatewayRequest object
Added example values for domainName to corresponding tests

Result:

After this change, users can access the domain name with:

struct ApiGatewayHandler: LambdaHandler {
	typealias Event  = APIGatewayRequest
	typealias Output = APIGatewayResponse

	func handle(_ event: Event, context: LambdaContext) async throws -> Output {
		...
		let domainName: String = event.domainName
		...
	}
}

MPLew-is added 2 commits

September 12, 2022 18:20


          Add domainName property to API Gateway V1 event

d31916a

According to [AWS example events](https://github.com/awsdocs/aws-lambda-developer-guide/blob/cad20e9f298fa16edfe0fb643ab8118b0fe2dc54/sample-apps/nodejs-apig/event.json) and documentation, this seems to be included in all requests.


          Add example domain name properties to tests

fb090f8

swift-server-bot commented Sep 13, 2022

Can one of the admins verify this patch?

5 similar comments

swift-server-bot commented Sep 13, 2022

Can one of the admins verify this patch?

swift-server-bot commented Sep 13, 2022

Can one of the admins verify this patch?

swift-server-bot commented Sep 13, 2022

Can one of the admins verify this patch?

swift-server-bot commented Sep 13, 2022

Can one of the admins verify this patch?

swift-server-bot commented Sep 13, 2022

Can one of the admins verify this patch?

tomerd reviewed

View reviewed changes

Sources/AWSLambdaEvents/APIGateway.swift Outdated Show resolved Hide resolved

Contributor

tomerd commented Sep 13, 2022

@swift-server-bot test this please


          Make domainName property optional

9fcee98

And add a test to make sure both cases successfully decode.

Contributor

tomerd commented Sep 13, 2022

@swift-server-bot test this please

tomerd enabled auto-merge (squash)

September 13, 2022 18:29

MPLew-is requested a review from tomerd

September 13, 2022 20:18

tomerd approved these changes

View reviewed changes

tomerd merged commit b415da2 into swift-server:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet