Make APIGatewayV2Request authorizer claims optional #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
3 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
@swift-server-bot test this please |
tomerd
approved these changes
Feb 10, 2022
|
example fixed in #9 |
|
@swift-server-bot test this please |
fabianfett
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make APIGatewayV2Request authorizer claims optional.
Motivation:
The current non-optional claims property is not compatible with the Lambda Runtime Interface Emulator.
Aside from this, the AWS Docs specify a
nullvalue in this example: https://docs.aws.amazon.com/apigateway/latest/developerguide/set-up-lambda-proxy-integrations.html#api-gateway-simple-proxy-for-lambda-input-formatModifications:
Make APIGatewayV2Request authorizer claims optional.
Result:
APIGatewayV2Request authorizer claims is optional, allowing a nil value so that the Lambda Runtime Interface Emulator works with this library and so it's in accordance with the AWS docs.