Add quotes to description where required #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* compatible swift3 * Merge pull request swiftcsv#2 from phpmaple/master * unify framework build settings for Xcode 8/Swift 3 * convert tests to Swift 3 * configure travis for Xcode 8 * lower deployment target * Merge pull request #1 from DivineDominion/swift-3 - fix Swift 3 conversion
* rename columns to namedColumns * move public interface properties into CSV.swift * move "named" field access to NamedView The parse() helper method masked the fact that rows and columns used to be lazily initialized; with NamedView as the base for both computed properties, a lazy initializer works just as well. * refactor enumerateAsArray into a static function * change CSV.header to be computable in the initializer The new static enumeration function helps make it possible to not keep `header` as a mutable force-unwrapped optional. * fix Swift documentation * rename parsing elements * refactor parse helpers * extract parsing state machine * rename CSV.rows to .namedRows * add EnumeratedView as a complementary to hash-based storage
* update code to Swift 4 * update project settings to Swift 4.1 * update to Swift 4.2 * update Travis CI settings * update newline detection for macOS
* update scheme names * update Travis CI script * make scheme names more canonical to platform names * remove unused setting
* update project settings * migrate to Swift 5 * add Swift 5 targets to travis * add tvOS 3 to targeted device families * use latest CocoaPods to support #swift_versions * fix failing tests (unsorted dictionary keys)
* make ParsingState throw instead of fatalError'ing out - extract enumerateAsDict as static - extract "view" creation into static helpers * extract view creation into initializer, adding a View protocol * fix tests for throwing * update README to show the API and errors * include meta files in the project * add commented-out test back in
* add SwiftPackageManager support. * add resourcehelper's file reference to fix test error in SwiftPM
* remove unused Variant type * disambiguate init(name:) to mean resource name, not file paths Fixes swiftcsv#39
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
==========================================
- Coverage 92.57% 92.53% -0.04%
==========================================
Files 14 14
Lines 431 402 -29
==========================================
- Hits 399 372 -27
+ Misses 32 30 -2
Continue to review full report at Codecov.
|
|
@DivineDominion Is there anything I can do to improve this PR? |
|
Thanks for the PR, @lukestringer90! I saw the list of commits in the email and deferred the review until I had more time -- but apparently you did only change a very small portion of the code and the rest is just noise :) I wonder how that came about. |
DivineDominion
approved these changes
Apr 11, 2020
|
Merged! Thanks a lot for contributing to SwiftCSV! We've invited you to join the SwiftCSV GitHub organization – no pressure to accept! If you'd like more information on what that means, check out our contributor guidelines. |
|
Thanks @DivineDominion for accepted my PR! I saw the big list of commits as well and I wasn't sure what happened as I only made a small change. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
descriptionproperty onCSVdoes not add quotes to values that have commas in them. This gives an incorrect representation of the CSV data as commas appear in the incorrect places.This PR adds double quotes around to values that have commas in them when generating the description.