Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments and translations #11

Merged
merged 14 commits into from
Mar 26, 2018
Merged

Comments and translations #11

merged 14 commits into from
Mar 26, 2018

Conversation

MrXyfir
Copy link

@MrXyfir MrXyfir commented Mar 25, 2018

I've added English comments for a small part of certain sections of the codebase. Many Chinese comments that once translated to English were redundant and so removed completely.

I make no guarantees about the accuracy of the comments. I think it's better than it was before but that's probably up for debate. Merge if you wish.

@adamstallard adamstallard merged commit f07227f into swiftdemand:master Mar 26, 2018
Copy link

@phamhongtuyen95 phamhongtuyen95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phamhongtuyen95
Copy link

I've added English comments for a small part of certain sections of the codebase. Many Chinese comments that once translated to English were redundant and so removed completely.

I make no guarantees about the accuracy of the comments. I think it's better than it was before but that's probably up for debate. Merge if you wish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants