Remove unused runtime library path on non-Darwin platforms #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finagolfin
added a commit
to finagolfin/swift
that referenced
this pull request
Jun 11, 2023
Translation of swiftlang/swift-driver#1374 to the legacy C++ Driver, with the addition of a test.
|
@stevapple and @kateinoigakukun, please let me know if this is okay on Windows and Wasm too. |
stevapple
suggested changes
Jun 12, 2023
stevapple
approved these changes
Jun 12, 2023
kateinoigakukun
approved these changes
Jun 12, 2023
|
@artemcm, this is the equivalent of my C++ Driver pull you just approved, would you test and merge both? |
|
@swift-ci test |
|
@artemcm, this one and the legacy driver backport linked above have passed all tests, just need you to approve and merge both. |
|
@artemcm, the upstream version of this pull that you approved has been merged, just need you to approve and merge this one too. |
artemcm
approved these changes
Jun 16, 2023
|
@swift-ci test |
|
@swift-ci test Windows platform |
finagolfin
added a commit
to finagolfin/swift
that referenced
this pull request
Jun 19, 2023
Translation of swiftlang/swift-driver#1374 to the legacy C++ Driver, with the addition of a test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes swiftlang/swift#63416