[SR-15661] Tests with "// REQUIRES: reflection" are unsupported

[benrimmington]

Previous ID	SR-15661
Radar	None
Original Reporter	@benrimmington
Type	Bug
Status	Closed
Resolution	Done

Additional Detail from JIRA

Votes	0
Component/s	Standard Library
Labels	Bug
Assignee	@kubamracek
Priority	Medium

md5: d2fb44b94d16bb19e6e948f38a900365

Issue Description:

// REQUIRES: reflection was added to stdlib tests in apple/swift#39030. However, lit.py doesn't list reflection in its available features, and so the stdlib tests are UNSUPPORTED (they fail to run).

lit.py: /Users/buildnode/jenkins/workspace/swift-PR-macos/branch-main/swift/test/lit.cfg:2496: note: Available features: CMAKE_GENERATOR=Ninja, CODEGENERATOR=AArch64, CODEGENERATOR=ARM, CODEGENERATOR=Mips, CODEGENERATOR=PowerPC, CODEGENERATOR=SystemZ, CODEGENERATOR=X86, CPU=x86_64, OS=macosx, PTRSIZE=64, SWIFT_VERSION=4, VENDOR=apple, asan_runtime, asserts, bootstrapping_with_hostlibs_mode, c_runtime, concurrency, concurrency_runtime, cplusplus_driver, crash-recovery, differentiable_programming, distributed, executable_test, foundation, fuzzer_runtime, libdispatch, libxml2, lld_lto, no_asan, no_lto, nonexecutable_test, objc_interop, optimized_stdlib, optimized_stdlib_x86_64, profile_runtime, reflection_test_support, runtime_function_counters, sftp_server, shell, sourcekit, string_processing, swift-remoteast-test, swift_in_compiler, swift_interpreter, swift_repl, swift_stable_abi, swift_stdlib_asserts, swift_test_mode_optimize_none, swift_test_mode_optimize_none_x86_64, swift_tools_extra, syntax_parser_lib, tsan_runtime, ubsan_runtime

UNSUPPORTED: Swift(macosx-x86_64) :: stdlib/DebuggerSupport.swift (7235 of 15203)
UNSUPPORTED: Swift(macosx-x86_64) :: stdlib/Error.swift (7248 of 15203)
UNSUPPORTED: Swift(macosx-x86_64) :: stdlib/ForEachField.swift (7259 of 15203)
UNSUPPORTED: Swift(macosx-x86_64) :: stdlib/Mirror.swift (7285 of 15203)
UNSUPPORTED: Swift(macosx-x86_64) :: stdlib/Optional.swift (7310 of 15203)
UNSUPPORTED: Swift(macosx-x86_64) :: stdlib/Print.swift (7314 of 15203)
UNSUPPORTED: Swift(macosx-x86_64) :: stdlib/PrintArray.swift (7315 of 15203)
UNSUPPORTED: Swift(macosx-x86_64) :: stdlib/PrintBoolean.swift (7316 of 15203)
UNSUPPORTED: Swift(macosx-x86_64) :: stdlib/PrintClass.swift (7318 of 15203)
UNSUPPORTED: Swift(macosx-x86_64) :: stdlib/PrintDictionary.swift (7319 of 15203)
UNSUPPORTED: Swift(macosx-x86_64) :: stdlib/PrintInteger.swift (7322 of 15203)
UNSUPPORTED: Swift(macosx-x86_64) :: stdlib/PrintPointer.swift (7323 of 15203)
UNSUPPORTED: Swift(macosx-x86_64) :: stdlib/PrintSet.swift (7324 of 15203)
UNSUPPORTED: Swift(macosx-x86_64) :: stdlib/PrintString.swift (7325 of 15203)
UNSUPPORTED: Swift(macosx-x86_64) :: stdlib/PrintStruct.swift (7326 of 15203)
UNSUPPORTED: Swift(macosx-x86_64) :: stdlib/PrintTuple.swift (7327 of 15203)
UNSUPPORTED: Swift(macosx-x86_64) :: stdlib/Reflection.swift (7334 of 15203)
UNSUPPORTED: Swift(macosx-x86_64) :: stdlib/ReflectionHashing.swift (7335 of 15203)
UNSUPPORTED: Swift(macosx-x86_64) :: stdlib/Runtime.swift.gyb (7342 of 15203)
UNSUPPORTED: Swift(macosx-x86_64) :: stdlib/RuntimeRetroactiveConformance.swift (7344 of 15203)
UNSUPPORTED: Swift(macosx-x86_64) :: stdlib/StaticPrint.swift (7355 of 15203)
UNSUPPORTED: Swift(macosx-x86_64) :: stdlib/StaticString.swift (7356 of 15203)
UNSUPPORTED: Swift(macosx-x86_64) :: stdlib/StringAPI.swift (7359 of 15203)
UNSUPPORTED: Swift(macosx-x86_64) :: stdlib/StringCompatibility.swift (7362 of 15203)
UNSUPPORTED: Swift(macosx-x86_64) :: stdlib/StringDescribing.swift (7367 of 15203)
UNSUPPORTED: Swift(macosx-x86_64) :: stdlib/UnicodeMetadata.swift (7387 of 15203)
UNSUPPORTED: Swift(macosx-x86_64) :: stdlib/UnsafePointer.swift.gyb (7391 of 15203)
UNSUPPORTED: Swift(macosx-x86_64) :: stdlib/WeakMirror.swift (7397 of 15203)
UNSUPPORTED: Swift(macosx-x86_64) :: stdlib/integer_conversions.swift (7402 of 15203)
UNSUPPORTED: Swift-validation(macosx-x86_64) :: stdlib/AnyHashable.swift.gyb (14892 of 15203)
UNSUPPORTED: Swift-validation(macosx-x86_64) :: stdlib/Array.swift.gyb (14893 of 15203)
UNSUPPORTED: Swift-validation(macosx-x86_64) :: stdlib/ArraySlice.swift.gyb (14911 of 15203)
UNSUPPORTED: Swift-validation(macosx-x86_64) :: stdlib/ContiguousArray.swift.gyb (14987 of 15203)
UNSUPPORTED: Swift-validation(macosx-x86_64) :: stdlib/Lazy.swift.gyb (15053 of 15203)
UNSUPPORTED: Swift-validation(macosx-x86_64) :: stdlib/NewArray.swift.gyb (15057 of 15203)
UNSUPPORTED: Swift-validation(macosx-x86_64) :: stdlib/Prototypes/PersistentVector.swift.gyb (15064 of 15203)
UNSUPPORTED: Swift-validation(macosx-x86_64) :: stdlib/Range.swift.gyb (15066 of 15203)

[benrimmington]

Cc: @kubamracek

[kubamracek]

#40720

[benrimmington]

In the build logs for apple/swift#40720, the validation tests are still unsupported:

UNSUPPORTED: Swift(macosx-x86_64) :: stdlib/StaticPrint.swift (7353 of 15201)
UNSUPPORTED: Swift-validation(macosx-x86_64) :: stdlib/AnyHashable.swift.gyb (14890 of 15201)
UNSUPPORTED: Swift-validation(macosx-x86_64) :: stdlib/Array.swift.gyb (14891 of 15201)
UNSUPPORTED: Swift-validation(macosx-x86_64) :: stdlib/ArraySlice.swift.gyb (14909 of 15201)
UNSUPPORTED: Swift-validation(macosx-x86_64) :: stdlib/ContiguousArray.swift.gyb (14985 of 15201)
UNSUPPORTED: Swift-validation(macosx-x86_64) :: stdlib/Lazy.swift.gyb (15051 of 15201)
UNSUPPORTED: Swift-validation(macosx-x86_64) :: stdlib/NewArray.swift.gyb (15055 of 15201)
UNSUPPORTED: Swift-validation(macosx-x86_64) :: stdlib/Prototypes/PersistentVector.swift.gyb (15062 of 15201)
UNSUPPORTED: Swift-validation(macosx-x86_64) :: stdlib/Range.swift.gyb (15064 of 15201)

[kubamracek]

Great catch, thanks for checking!

#40737

[kubamracek]

Should be fixed now!

[benrimmington]

Thanks. I've verified that the tests and validation-tests are now passing.

(Except for stdlib/StaticPrint.swift which also REQUIRES: stdlib_static_print.)