Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stdlib] Implement updates to SE-0104 #11203

Merged
merged 6 commits into from
Jul 28, 2017
Merged

[stdlib] Implement updates to SE-0104 #11203

merged 6 commits into from
Jul 28, 2017

Conversation

moiseev
Copy link
Contributor

@moiseev moiseev commented Jul 26, 2017 •
edited
Loading

  • Delete ArithmeticOverflow type
  • Make BinaryInteger.init generic over BinaryFloatingPoint instead of FloatingPoint
  • Rename init(extendingOrTruncating:) to init(truncatingIfNeeded:)

Shift operation changes can be found here.

@moiseev
Copy link
Contributor Author

moiseev commented Jul 26, 2017

@swift-ci Please test macOS platform

@moiseev
Copy link
Contributor Author

moiseev commented Jul 26, 2017

@swift-ci Please smoke benchmark

@moiseev
Copy link
Contributor Author

moiseev commented Jul 26, 2017

@swift-ci Please Test Source Compatibility

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 1c3e597
Test requested by - @moiseev

@swift-ci
Copy link
Contributor

Build comment file:

Build failed before running benchmark.

This was referenced Jul 27, 2017
Merged
Merged
@moiseev
Copy link
Contributor Author

moiseev commented Jul 27, 2017

swiftlang/swift-corelibs-foundation#1136
swiftlang/swift-package-manager#1289
@swift-ci Please test Linux platform

@moiseev
Copy link
Contributor Author

moiseev commented Jul 27, 2017

@swift-ci Please test macOS platform

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 1c3e597
Test requested by - @moiseev

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 1c3e597
Test requested by - @moiseev

@moiseev moiseev mentioned this pull request Jul 27, 2017
Merged
@moiseev
Copy link
Contributor Author

moiseev commented Jul 27, 2017

@swift-ci Please Test Source Compatibility

@moiseev
Copy link
Contributor Author

moiseev commented Jul 27, 2017

swiftlang/swift-package-manager#1289
@swift-ci Please test macOS

@moiseev
Copy link
Contributor Author

moiseev commented Jul 27, 2017

@swift-ci Please Test Source Compatibility

1 similar comment
@moiseev
Copy link
Contributor Author

moiseev commented Jul 27, 2017

@swift-ci Please Test Source Compatibility

@natecook1000
Copy link
Member

swiftlang/swift-package-manager#1289
@swift-ci Please Test Source Compatibility

@natecook1000
Copy link
Member

swiftlang/swift-corelibs-foundation#1136
swiftlang/swift-package-manager#1289
@swift-ci Please test Linux platform

@natecook1000
Copy link
Member

swiftlang/swift-package-manager#1289
@swift-ci Please test macOS platform

@swiftlang swiftlang deleted a comment from swift-ci Jul 28, 2017
@swiftlang swiftlang deleted a comment from swift-ci Jul 28, 2017
@moiseev
Copy link
Contributor Author

moiseev commented Jul 28, 2017

swiftlang/swift-corelibs-foundation#1136
swiftlang/swift-package-manager#1289
@swift-ci Please test

@swiftlang swiftlang deleted a comment from swift-ci Jul 28, 2017
@swiftlang swiftlang deleted a comment from swift-ci Jul 28, 2017
@shahmishal
Copy link
Member

swiftlang/swift-corelibs-foundation#1136
swiftlang/swift-package-manager#1289
@swift-ci Please test

@moiseev
Copy link
Contributor Author

moiseev commented Jul 28, 2017

@swift-ci Please Test Source Compatibility

@moiseev moiseev merged commit 3f993ef into swiftlang:master Jul 28, 2017
@moiseev moiseev deleted the integers-revised branch July 28, 2017 23:16
@humiaozuzu humiaozuzu mentioned this pull request Aug 29, 2017
Closed
benrimmington added a commit to swiftlang/swift-evolution that referenced this pull request Sep 3, 2017
@benrimmington
[SE-0104 Revision 4] Implemented (Swift 4)
abe20ba 
* <swiftlang/swift#11044>
* <swiftlang/swift#11203>
@benrimmington benrimmington mentioned this pull request Sep 3, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@moiseev @swift-ci @natecook1000 @shahmishal