[5.6] SILGen: Add missing processing to reabstraction fast-path. #41774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling into foreign-convention functions requires bridging, and the code that bypassed reabstraction conversions failed to take this into account. Fixes SR-15696 | rdar://89319249. (cherry picked from commit fb178c6)
|
@jckarter I submitted this figuring it is good to fix in the near term |
|
@swift-ci please test |
|
@DougGregor now that 5.6 is released can you consider this for a .1? |
|
@DougGregor now that 5.6 is released can you consider this for a .1? |
|
@swift-ci Please smoke test |
airspeedswift
approved these changes
Apr 7, 2022
keith
deleted the
ks/5.6-silgen-add-missing-processing-to-reabstraction-fast-path
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling into foreign-convention functions requires bridging, and the code
that bypassed reabstraction conversions failed to take this into account.
Fixes SR-15696 | rdar://89319249.
(cherry picked from commit fb178c6)