[ConstraintSystem] Allow injecting callAsFunction after defaulted arguments
#59432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please build toolchain macos |
If current parameter cannot accept a trailing closure, let's match current closure argument to it only if there is absolutely no possible other choice e.g. no other parameters (defaulted or not) that could accept the closure via a less restrictive backward scan.
Detect that extraneous closure belongs to `.init` call on a callable type and let the solver inject `.callAsFunction` before fixing it. This prevents incorrect "extraneous trailing closure" diagnostic when issue is located inside of the closure itself.
|
@swift-ci please build toolchain macos |
|
@swift-ci please test source compatibility |
|
@swift-ci please test |
hborla
approved these changes
Jun 15, 2022
|
@swift-ci please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust argument matching to be less aggressive while matching misplaced trailing closures
against defaulted parameters that do not accept trailing closures.
For example:
Trailing closure in this case should be marked as "extraneous" instead of matched
against parameter
a:.If trailing closure is extraneous in a call to
.initon callable type, let's not attempt toto fix it and allow solver to inject
.callAsFunctionfirst.Resolves: rdar://problem/94959816