Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.9] [Macros] Improve parsing, representation, and serialization of role attributes #65363

Conversation

DougGregor
Copy link
Member

@DougGregor DougGregor commented Apr 21, 2023

  • Explanation: Parse compound and special names in the macro role attributes (@freestanding and @attached). This allows both compound names and initializers, e.g., init(coding:).
  • Scope: Affects code declaring macros that generate declarations.
  • Risk: Low, narrowly applied to macros that introduce declarations.
  • Issue: rdar://107967344.
  • Original pull request: [Macros] Improve parsing, representation, and serialization of role attributes #65362

…ttributes

Parse compound and special names in the macro role attributes
(`@freestanding` and `@attached`). This allows both compound names and
initializers, e.g., `init(coding:)`.

Fixes rdar://107967344.
@DougGregor DougGregor requested a review from a team as a code owner April 21, 2023 18:39
@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor DougGregor merged commit febedf4 into swiftlang:release/5.9 Apr 22, 2023
@DougGregor DougGregor deleted the macro-compound-introduced-names-5.9 branch April 22, 2023 00:51
@AnthonyLatsis AnthonyLatsis added the 🍒 release cherry pick Flag: Release branch cherry picks label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants