build: enable control over the C++ interop modules #65398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please build toolchain windows platform |
|
Thanks, Saleem! This looks great. |
zoecarver
approved these changes
Apr 24, 2023
edymtt
reviewed
Apr 24, 2023
edymtt
reviewed
Apr 24, 2023
|
@swift-ci please test |
compnerd
force-pushed
the
interop-control
branch
from
0924c36
to
40bbed1
Compare
|
@swift-ci please test |
edymtt
reviewed
Apr 26, 2023
Treat the C++ interop modules similar to the Concurrency and StringProcessing modules, enabled through a top-level global flag. The flag now enables disabling the C++ interop modules when the standard library is built. Based on the original work by Egor Zhdan!
compnerd
force-pushed
the
interop-control
branch
from
40bbed1
to
f116173
Compare
|
@swift-ci please test |
egorzhdan
added a commit
that referenced
this pull request
May 2, 2023
…EROP=NO` This fixes the Swift LSAN CI job Linux (https://ci.swift.org/job/oss-swift-RA-lsan-linux-ubuntu-18_04/) that started failing after #65398. rdar://108674065
egorzhdan
added a commit
that referenced
this pull request
May 14, 2023
…EROP=NO` This fixes the Swift LSAN CI job Linux (https://ci.swift.org/job/oss-swift-RA-lsan-linux-ubuntu-18_04/) that started failing after #65398. rdar://108674065 (cherry picked from commit b586604)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treat the C++ interop modules similar to the Concurrency and StringProcessing modules, enabled through a top-level global flag. The flag now enables disabling the C++ interop modules when the standard library is built.
Based on the original work by Egor Zhdan!