Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanups and fixes for opened existentials #69950

Merged
merged 10 commits into from
Nov 28, 2023
Merged

Cleanups and fixes for opened existentials #69950

merged 10 commits into from
Nov 28, 2023

Conversation

slavapestov
Copy link
Contributor

Also:

  • Removes the 'inferred result type requires explicit coercion' diagnostic, which was meant to hold down the fort until constrained existential types landed. At this point it's no longer helpful, and the check it tries to perform is actually very difficult if not impossible to implement correctly.
  • Cleans up duplicated logic for erasing opened existentials.

@slavapestov
Copy link
Contributor Author

@swift-ci Please test

@slavapestov
Copy link
Contributor Author

@swift-ci Please test source compatibility

@slavapestov
Sema: Strip off LValueType from opened existential accesses with an e…
ef6630f 
…rased result type

- Fixes swiftlang#62219
- Fixes swiftlang#60619,
- Fixes rdar://104230391
- Fixes rdar://118247162.
@slavapestov
Sema: Remove 'inferred result type requires explicit coercion' diagno…
1b1963e 
…stic
@slavapestov
AST: Use ArchetypeType::getExistentialType() in a couple of places
c298997
@slavapestov
AST: Merge GenericSignature::get{Non,}DependentUpperBounds()
f5e2505
@slavapestov
Sema: Don't need to pass parent signature to OpenedArchetypeType::get()
5bb82f7
@slavapestov
AST: Remove useDC parameter from typeEraseOpenedArchetypesWithRoot()
ef99de0
@slavapestov
Sema: Simplify typeEraseExistentialSelfReferences()
04577fe
@slavapestov
AST: Move TypeBase::typeEraseOpenedArchetypesWithRoot() into Constrai…
c0f9d29 
…ntSystem.cpp
@slavapestov
Sema: Extract duplication between typeEraseOpenedExistentialReference…
8172343 
…() and typeEraseOpenedArchetypesWithRoot()
@slavapestov
Sema: Simplify recursion in typeEraseExistentialSelfReferences()
6fb5b94
@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@slavapestov slavapestov merged commit f89b981 into swiftlang:main Nov 28, 2023
3 checks passed
xedin added a commit to xedin/swift that referenced this pull request Jan 24, 2024
@xedin
[Sema] Temporary disable l-value stripping while erasing opened exist…
d8ed3a9 
…entials

Reverts part of swiftlang#69950 because
it causes failure in existing code.
@xedin xedin mentioned this pull request Jan 24, 2024
Merged
xedin added a commit to xedin/swift that referenced this pull request Jan 24, 2024
@xedin
[Sema] Temporary disable l-value stripping while erasing opened exist…
3d74a39 
…entials

Reverts part of swiftlang#69950 because
it causes failure in existing code.
carlos4242 pushed a commit to carlos4242/swift that referenced this pull request May 31, 2024
@xedin
[Sema] Temporary disable l-value stripping while erasing opened exist…
6fab45c 
…entials

Reverts part of swiftlang#69950 because
it causes failure in existing code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xedin xedin xedin approved these changes

@AnthonyLatsis AnthonyLatsis Awaiting requested review from AnthonyLatsis AnthonyLatsis is a code owner

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@angela-laar angela-laar Awaiting requested review from angela-laar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@slavapestov @xedin