[5.10][SE-0392] Back-deploy assertIsolation/assumeIsolation #70474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SILGen and IRGen would disagree on the return type of the `swift_task_getMainExecutor()` runtime function if `SILGenModule::getGetMainExecutor()` had ever been called. To address this, consistently use the `buildMainActorExecutorRef` built-in and get rid of `SILGenModule::getGetMainExecutor()`. Resolves rdar://116472583
The assertIsolation/assumeIsolation operations on actors are back-deployable back to the introduction of concurrency. Do so. Resolves rdar://111880539
tshortli
added
🍒 release cherry pick
|
@swift-ci please test |
ktoso
approved these changes
Dec 14, 2023
airspeedswift
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assertIsolation/assumeIsolationoperations on actors are back-deployable back to the introduction of concurrency. However, doing so revealed that SILGen and IRGen could disagree on the return type ofswift_task_getMainExecutor(), so fix that too to unblock adoption of the@backDeployedattribute.main()function.assertIsolationandassumeIsolationAPIs are not changing; only their back deployment eligibility has changed. The new codegen that uses a builtin to reference the main actor executor should be functionally equivalent to the previous codegen. The builtin was already used during IRGen previously and this change simply makes its use more consistent.mainPR: [SE-0392] Back-deploy assertIsolation/assumeIsolation #70472