Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform: add sys_xattr module for Android #74742

Merged
merged 1 commit into from
Jun 29, 2024
Merged

Conversation

compnerd
Copy link
Member

This module was left out from the modulariation pass. The declarations here are required for building swift-foundation for Android.

@compnerd compnerd requested a review from a team as a code owner June 26, 2024 18:35
@compnerd compnerd requested review from hyp and ian-twilightcoder and removed request for a team and hyp June 26, 2024 18:35
@compnerd
Copy link
Member Author

@swift-ci please test

@hyp
Copy link
Contributor

hyp commented Jun 26, 2024

@compnerd could you also include it from SwiftAndroidNDK.h?

@compnerd
Copy link
Member Author

Sure, though could you explain why that is needed?

This module was left out from the modulariation pass. The declarations
here are required for building swift-foundation for Android.
@compnerd
Copy link
Member Author

@swift-ci please test

@finagolfin
Copy link
Contributor

I haven't tried building the new swift-foundation lately, but I will apply this NDK header addition natively on Android and test to make sure it doesn't break anything.

@compnerd
Copy link
Member Author

I've tested the android build locally, and this is needed to make progress on the swift-foundation builds for Android. Additionally, the introduced module is an explicit module which was previously not included, so I do not expect this to cause any regressions.

@finagolfin
Copy link
Contributor

I don't either, just running the compiler validation suite with it natively on Android now.

@finagolfin
Copy link
Contributor

Alright, ran the full compiler validation suite natively on Android with this pull and am building a full trunk toolchain with it now, don't see any issues.

@compnerd
Copy link
Member Author

compnerd commented Jun 28, 2024

Okay, would be nice to merge this for now. We can address any issues subsequently. Hopefully we can get to the point where we can get swift-foundation android builds via cross-compilation in CI as well. Or would you rather report back quickly @finagolfin?

@finagolfin
Copy link
Contributor

Okay, would be nice to merge this for now. We can address any issues subsequently.

If you need it to build swift-foundation, seems fine to me.

Hopefully we can get to the point where we can get swift-foundation android builds via cross-compilation in CI as well. Or would you rather report back quickly @finagolfin?

I don't understand: what do you want me to report back about?

@compnerd
Copy link
Member Author

Oh, I thought you were doing more tests. Going to merge!

@compnerd compnerd merged commit 3f3b0b3 into swiftlang:main Jun 29, 2024
5 checks passed
@compnerd compnerd deleted the extended branch June 29, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants