Fix the build for newer Xcodes #75902
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should allow situations where one of the pair being zippered is arm64e and the other is aarch64; provided the actual code is arm64e, this should work just fine.
These belong in `<math.h>` and declaring them in the shims causes modularisation problems.
The Darwin module is part of the SDK and shouldn't be duplicated in the Swift repo; doing so is causing modularisation issues.
The Darwin module is part of the SDK, and having a separate variant of it causes modularisation issues. It might be desirable to reinstate this, but doing so will require that we resolve some issues.
…tforms. We need the OSS version of the compiler to cope with `@_originallyDefinedIn` from SDKs that might feature platform names that it doesn't understand. At the very least, it shouldn't emit a confusing diagnostic claiming that they are missing when they are not.
|
@swift-ci Please test |
|
The |
|
All of this should be fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some build problems we're seeing with newer Xcodes.
This probably shouldn't be merged as-is because (among other things) the
lgamma_r()function needs somehow to be conditionally declared inLibcShims.hdepending on whether or not it's inmath.h, which is something this doesn't really attempt to fix (I just removed it completely).Additionally, I don't know what the impact of removing
embedded-darwinmight be outside of fixing the build.