Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.0] Fix ABI mismatch involving Sendable-refining non-resilient protocols and deployment targets #76383

Conversation

DougGregor
Copy link
Member

@DougGregor DougGregor commented Sep 10, 2024

… targets

A change to the way we determined whether a protocol conformance is
"dependent" for marker protocols caused an ABI break for
Sendable-refining protocols built with pre-6.0 Swift compilers. The
fix for this issue (swiftlang#75769)
gated the change on deployment target.

The deployment target change fixed the original problem, then caused a
related issue when a project mixes deployment targets (pre-6.0 and
6.0+) with non-resilient protocols. Exempt non-resilient protocols from
this change so we get consistent behavior.

Fixes rdar://134953989.
@DougGregor DougGregor requested a review from a team as a code owner September 10, 2024 19:48
@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor DougGregor merged commit 5bbf725 into swiftlang:release/6.0 Sep 11, 2024
5 checks passed
@DougGregor DougGregor deleted the sendable-refine-abi-nonresilient-6.0 branch September 11, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants