[WIP] Align pretty-printed diagnostic messages with source code that uses horizontal whitespace characters other than space (U+0020) #167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a few problems with the pretty-printed diagnostics.
Given a short Tokamak program as follows:
carton dev
provides the following diagnosis:The most noticeable problem in the diagnostics is that the "^"s don't point to where the errors actually are. This pull request intends to address this problem by first stripping all leading whitespace in the pretty-printed source code, then copying any remaining whitespace verbatim to the indentation before each "^".
Some other problems include duplicated error messages and out-of-order diagnosis. I intend to address them in follow-up PRs.