Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚙️ Keep --result-bundle-path only in full build and cache commands #287

Merged
merged 3 commits into from
Nov 25, 2023

Conversation

swiftyfinch
Copy link
Owner

Description

I've kept --result-bundle-path only in full build and cache commands.
This option is passed to xcodebuild which is used only in these commands.

References

  • None

Checklist (I have ...)

  • 🧐 Followed the code style of the rest of the project
  • 📖 Updated the documentation, if necessary
  • 👨🏻‍🔧 Added at least one test which validates that my change is working, if appropriate
  • 👮🏻‍♂️ Run make lint and fixed all warnings
  • ✅ Run make test and fixed all tests

❤️ Thanks for contributing to the 🏈 Rugby!

@swiftyfinch swiftyfinch added the ⚙️ Engineering Task Technical stuff label Nov 25, 2023
@swiftyfinch swiftyfinch self-assigned this Nov 25, 2023
Copy link

codecov bot commented Nov 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (56cef9b) 36.59% compared to head (c784c30) 36.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #287   +/-   ##
=======================================
  Coverage   36.59%   36.59%           
=======================================
  Files         142      142           
  Lines        4164     4164           
=======================================
  Hits         1524     1524           
  Misses       2640     2640           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swiftyfinch swiftyfinch marked this pull request as ready for review November 25, 2023 09:18
@swiftyfinch swiftyfinch merged commit 4435df6 into main Nov 25, 2023
11 checks passed
@swiftyfinch swiftyfinch deleted the result-bundle-build branch November 25, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant