Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test page and attestation logic #395

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Remove test page and attestation logic #395

merged 1 commit into from
Sep 22, 2022

Conversation

wormat
Copy link
Collaborator

@wormat wormat commented Sep 22, 2022

It's getting annoying updating this dud page with all the SDK changes.

Notion ticket: https://www.notion.so/exsphere/Delete-TestPage-and-reimplement-functionality-as-script-bb82610475104156ac42ad3a631520de (Step 1)

Checklist

  • Github project and label have been assigned
  • Tests have been added or are unnecessary
  • Docs have been updated or are unnecessary
  • Preview deployment works (visit the Cloudflare preview URL)
  • Manual testing in #product-testing completed or unnecessary
  • New i18n strings do not contain any security vulnerabilities (e.g. should not allow translator to update email/url)
  • When fetching new translations from external sources, do a sanity check (e.g. get people who speak the language to check, shove all new translations into Google translate)

The logic will be reimplemented in the SDK and the test page functionality will be reborn as
scripts.
@github-actions
Copy link

✨ Deployment complete! Take a peek over at https://0b3a453a.ui-storybook.pages.dev

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d898342
Status: ✅  Deploy successful!
Preview URL: https://f4e007d5.swim-ui.pages.dev
Branch Preview URL: https://ui-rm-test-page.swim-ui.pages.dev

View logs

@wormat wormat merged commit 41885b7 into master Sep 22, 2022
@wormat wormat deleted the ui/rm-test-page branch September 22, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants