Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(solana): invalid cjs build due to @project-serum/sol-wallet-adapter contains esm code #408

Merged
merged 3 commits into from
Sep 30, 2022
Merged

fix(solana): invalid cjs build due to @project-serum/sol-wallet-adapter contains esm code #408

merged 3 commits into from
Sep 30, 2022

Conversation

swimthor
Copy link
Contributor

@swimthor swimthor commented Sep 29, 2022 •
edited
Loading

Slack: https://exsphere.slack.com/archives/C03HGGJ0N4F/p1664453452086789
Notion ticket: N/A

Checklist

  • Github project and label have been assigned
  • Tests have been added or are unnecessary
  • Docs have been updated or are unnecessary
  • Preview deployment works (visit the Cloudflare preview URL)
  • Manual testing in #product-testing completed or unnecessary
  • New i18n strings do not contain any security vulnerabilities (e.g. should not allow translator to update email/url)
  • When fetching new translations from external sources, do a sanity check (e.g. get people who speak the language to check, shove all new translations into Google translate)

@swimthor swimthor added the bug Something isn't working label Sep 29, 2022
@swimthor swimthor self-assigned this Sep 29, 2022
swimthor
swimthor commented Sep 29, 2022
View reviewed changes
apps/ui/package.json Outdated Show resolved Hide resolved
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 29, 2022 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8bc2fdc
Status: ✅  Deploy successful!
Preview URL: https://7655e91a.swim-ui.pages.dev
Branch Preview URL: https://fix-solana-sdk-cjs.swim-ui.pages.dev

View logs

@swimthor swimthor changed the title fix(solana): invalid cjs build due to @project-serum/sol-wallet-adapter contains esm code [WIP] fix(solana): invalid cjs build due to @project-serum/sol-wallet-adapter contains esm code Sep 29, 2022
@swimthor swimthor changed the title [WIP] fix(solana): invalid cjs build due to @project-serum/sol-wallet-adapter contains esm code fix(solana): invalid cjs build due to @project-serum/sol-wallet-adapter contains esm code Sep 29, 2022
@swimthor swimthor force-pushed the fix-solana-sdk-cjs branch 2 times, most recently from 2a351b9 to 8e4ed21 Compare September 29, 2022 16:27
wormat
wormat previously approved these changes Sep 29, 2022
View reviewed changes
@github-actions
Copy link

✨ Deployment complete! Take a peek over at https://ecc32ad7.ui-storybook.pages.dev

@swimthor swimthor merged commit 1222e73 into master Sep 30, 2022
@swimthor swimthor deleted the fix-solana-sdk-cjs branch September 30, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wormat wormat wormat approved these changes

@nicomiicro nicomiicro Awaiting requested review from nicomiicro

Assignees

@swimthor swimthor

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swimthor @wormat