Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add token configs to SDK #411

Merged
merged 15 commits into from
Oct 4, 2022
Merged

Conversation

wormat
Copy link
Collaborator

@wormat wormat commented Oct 3, 2022

Notion ticket: Part of https://www.notion.so/exsphere/Use-SDK-configs-be0f3d23cae54f1594777a2d00de0007

Checklist

  • Github project and label have been assigned
  • Tests have been added or are unnecessary
  • Docs have been updated or are unnecessary
  • Preview deployment works (visit the Cloudflare preview URL)
  • Manual testing in #product-testing completed or unnecessary
  • New i18n strings do not contain any security vulnerabilities (e.g. should not allow translator to update email/url)
  • When fetching new translations from external sources, do a sanity check (e.g. get people who speak the language to check, shove all new translations into Google translate)

@wormat wormat added the feature New feature or request label Oct 3, 2022
@wormat wormat requested a review from nicomiicro October 3, 2022 17:36
Comment on lines 288 to 297
tokens: [
{
isDisabled: !process.env.REACT_APP_ENABLE_POOL_RESTRUCTURE,
id: "testnet-swimusd",
projectId: TokenProjectId.SwimLpSolanaUsdcUsdt,
nativeDetails: {
address: "3ngTtoyP9GFybFifX1dr7gCFXFiM2Wr6NfXn6EuU7k6C", // TODO: Update
decimals: 6,
},
wrappedDetails: new Map([
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually the swimUSD used by the restructured pools. Since we want to bring back the Wormhole form I guess we have to add a swimUSD wrappedDetails section to the chain config and remove this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this was a stupid comment. The wrapped details here will be the native details on each other chain.

Copy link
Contributor

@nicomiicro nicomiicro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!
I guess we could use them in ui/src/config/tokens too, right? Is it left for later?

@wormat
Copy link
Collaborator Author

wormat commented Oct 4, 2022

I guess we could use them in ui/src/config/tokens too, right? Is it left for later?

Yes, that's the plan but that's a bigger refactoring job.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 4, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8aa210d
Status: ✅  Deploy successful!
Preview URL: https://814eaf03.swim-ui.pages.dev
Branch Preview URL: https://sdk-token-configs.swim-ui.pages.dev

View logs

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

✨ Deployment complete! Take a peek over at https://1865fd2e.ui-storybook.pages.dev

Copy link
Contributor

@nicomiicro nicomiicro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

@wormat wormat merged commit 9903143 into sdk/standard-wormhole-methods Oct 4, 2022
@wormat wormat deleted the sdk/token-configs branch October 4, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants