Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ui): decode two pool state with IDL #446

Merged
merged 2 commits into from
Oct 20, 2022
Merged

chore(ui): decode two pool state with IDL #446

merged 2 commits into from
Oct 20, 2022

Conversation

ramenuncle
Copy link
Contributor

Prevent two pool state out of sync, using IDL instead of hardcoded layout to decode solana pool state.

Checklist

  • Github project and label have been assigned
  • Tests have been added or are unnecessary
  • Docs have been updated or are unnecessary
  • Preview deployment works (visit the Cloudflare preview URL)
  • Manual testing in #product-testing completed or unnecessary
  • New i18n strings do not contain any security vulnerabilities (e.g. should not allow translator to update email/url)
  • When fetching new translations from external sources, do a sanity check (e.g. get people who speak the language to check, shove all new translations into Google translate)

@ramenuncle ramenuncle added refactoring improvement Improving an existing feature labels Oct 18, 2022
@ramenuncle ramenuncle self-assigned this Oct 18, 2022
@github-actions
Copy link

github-actions bot commented Oct 18, 2022 •
edited
Loading

✨ Deployment complete! Take a peek over at https://3943640a.ui-storybook.pages.dev

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 18, 2022 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 318fe46
Status: ✅  Deploy successful!
Preview URL: https://0acef04c.swim-ui.pages.dev
Branch Preview URL: https://ui-decode-two-pool-with-idl.swim-ui.pages.dev

View logs

wormat
wormat reviewed Oct 18, 2022
View reviewed changes
Copy link
Collaborator

@wormat wormat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. We'll be adding helpers for this to the SDK soon.

apps/ui/src/models/swim/deserializeSwimPoolV2.ts Outdated Show resolved Hide resolved
apps/ui/src/models/swim/deserializeSwimPoolV2.ts Show resolved Hide resolved
apps/ui/src/models/swim/deserializeSwimPoolV2.ts Outdated Show resolved Hide resolved
@ramenuncle ramenuncle marked this pull request as ready for review October 19, 2022 16:57
@ramenuncle ramenuncle merged commit 3599287 into master Oct 20, 2022
@ramenuncle ramenuncle deleted the ui/decode-two-pool-with-idl branch October 20, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wormat wormat wormat approved these changes

@swimthor swimthor Awaiting requested review from swimthor

Assignees

@ramenuncle ramenuncle

Labels
improvement Improving an existing feature refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramenuncle @wormat