Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I found bug in technique.py line 71 #2

Closed
skyWalker1997 opened this issue Jul 25, 2019 · 1 comment · Fixed by #22
Closed

I found bug in technique.py line 71 #2

skyWalker1997 opened this issue Jul 25, 2019 · 1 comment · Fixed by #22

Comments

@skyWalker1997
Copy link

original code in line 71
temp_list = phase['phase_name']

Because many att&ck techniques can be used in several phases of kill chain, so you should use append for variable 'temp_list'

Code in line 71 should be changed to :
temp_list.append(phase['phase_name'])
@skyWalker1997 skyWalker1997 mentioned this issue Jul 25, 2019
Closed
joshswimlane added a commit that referenced this issue Aug 12, 2019
@joshswimlane
#3 #2 - Fixed issue related to appending techniques correctly
bf3366c
@joshswimlane joshswimlane mentioned this issue Aug 12, 2019
Merged
joshswimlane added a commit that referenced this issue Aug 12, 2019
@joshswimlane
Merge pull request #4 from swimlane/fixed_appending_techniques_issue
7b17d0a 
#3 #2 - Fixed issue related to appending techniques correctly
@joshswimlane
Copy link
Contributor

This should be fixed - pushing to pypi soon

@joshswimlane joshswimlane linked a pull request Feb 19, 2020 that will close this issue
Initial Release of pyattck v2 #22
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Initial Release of pyattck v2 swimlane/pyattck
2 participants
@skyWalker1997 @joshswimlane