Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server bindings #17

Merged
merged 35 commits into from
Nov 9, 2023
Merged

Server bindings #17

merged 35 commits into from
Nov 9, 2023

Conversation

SirCipher
Copy link
Member

No description provided.

…nto server-bindings

# Conflicts:
#	rust-java-bridge/Cargo.toml
#	rust-java-bridge/swim_client/src/lib.rs
#	swim-java/settings.gradle
#	swim-java/swim-client/build.gradle
#	swim-java/swim-client/src/main/java/ai/swim/client/downlink/DownlinkConfig.java
#	swim-java/swim-client/src/main/java/ai/swim/client/downlink/TriConsumer.java
#	swim-java/swim-client/src/main/java/ai/swim/client/lifecycle/OnClear.java
#	swim-java/swim-client/src/main/java/ai/swim/client/lifecycle/OnRemove.java
#	swim-java/swim-client/src/test/java/ai/swim/client/downlink/value/ValueDownlinkTest.java
#	swim-java/swim-core/swim-concurrent/src/main/java/ai/swim/concurrent/Trigger.java
#	swim-java/swim-core/swim-structure/src/main/java/ai/swim/structure/recognizer/structural/PolymorphicRecognizer.java
#	swim-java/swim-ffi/swim.lang.ffi/src/main/java/ai/swim/lang/ffi/NativeResourceException.java
…o server-bindings

# Conflicts:
#	swim-java/swim-client/src/main/java/ai/swim/client/SwimClient.java
#	swim-java/swim-client/src/test/java/ai/swim/client/downlink/value/ValueDownlinkTest.java
…rver-bindings

# Conflicts:
#	rust-java-bridge/Cargo.toml
#	rust-java-bridge/jvm_sys/Cargo.toml
#	rust-java-bridge/jvm_sys/jvm_sys_tests/src/lib.rs
#	rust-java-bridge/jvm_sys/src/lib.rs
#	rust-java-bridge/jvm_sys/src/vm/method.rs
#	rust-java-bridge/jvm_sys/src/vm/mod.rs
#	rust-java-bridge/jvm_sys/src/vm/utils.rs
#	rust-java-bridge/rust-java-bridge.iml
#	rust-java-bridge/swim_client/src/lib.rs
#	rust-java-bridge/swim_client/swim_client_core/src/downlink/map/lifecycle.rs
#	rust-java-bridge/swim_client/swim_client_core/src/downlink/map/mod.rs
#	rust-java-bridge/swim_client/swim_client_core/src/downlink/value/lifecycle.rs
#	rust-java-bridge/swim_client/swim_client_core/src/downlink/value/mod.rs
#	rust-java-bridge/swim_client/swim_client_core/src/downlink/vtable.rs
#	rust-java-bridge/swim_client/swim_client_core/src/lib.rs
#	rust-java-bridge/swim_client/swim_client_test/src/lib.rs
#	rust-java-bridge/swim_client/swim_client_test/src/value.rs
#	swim-java/swim-client/src/main/java/ai/swim/client/SwimClient.java
#	swim-java/swim-client/src/main/java/ai/swim/client/downlink/DownlinkConfig.java
#	swim-java/swim-client/src/test/java/ai/swim/client/downlink/map/MapDownlinkTest.java
#	swim-java/swim-client/src/test/java/ai/swim/client/downlink/value/ValueDownlinkTest.java
#	swim-java/swim-core/swim-structure/src/main/java/ai/swim/structure/recognizer/SimpleRecognizer.java
#	swim-rust
@SirCipher SirCipher marked this pull request as ready for review September 25, 2023 15:36
…erver-bindings

# Conflicts:
#	rust-java-bridge/jvm_sys/Cargo.toml
#	rust-java-bridge/jvm_sys/src/env.rs
…erver-bindings

# Conflicts:
#	swim-java/checkstyle.xml
#	swim-java/cookbook/value_downlink/src/main/java/swim/cookbook/CustomClient.java
#	swim-java/swim-client/src/main/java/ai/swim/client/downlink/map/MapDownlinkBuilder.java
#	swim-java/swim-client/src/main/java/ai/swim/client/downlink/map/MapDownlinkModel.java
#	swim-java/swim-client/src/test/java/ai/swim/client/downlink/value/ValueDownlinkTest.java
Copy link

@horned-sphere horned-sphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of the new types (in Rust and Java) are very light on doc comments/comments at all.

Also, I checked it out to look more closely at a couple of things and cargo check on "rust-java-bridge" fails with:

error: failed to load manifest for workspace member `/Users/greg/projects/swim-rust-ffi/rust-java-bridge/swim_client`

Caused by:
  failed to load manifest for dependency `runtime`

Caused by:
  failed to read `/Users/greg/projects/swim-rust-ffi/swim-rust/client/runtime/Cargo.toml`

Caused by:
  No such file or directory (os error 2)

rust-java-bridge/jvm_sys/src/bridge.rs Show resolved Hide resolved
rust-java-bridge/jvm_sys/src/env.rs Show resolved Hide resolved
rust-java-bridge/jvm_sys/src/bridge.rs Outdated Show resolved Hide resolved
rust-java-bridge/jvm_sys/src/env.rs Outdated Show resolved Hide resolved
rust-java-bridge/jvm_sys/src/env.rs Outdated Show resolved Hide resolved
rust-java-bridge/jvm_sys/src/macros.rs Outdated Show resolved Hide resolved
rust-java-bridge/swim_server/swim_server_core/src/lib.rs Outdated Show resolved Hide resolved
@SirCipher
Copy link
Member Author

@horned-sphere, you need to check out the swim-rust submodule that's in the repo - I should add some instructions.

I'll work on your other comments and add some documentation.

@SirCipher SirCipher merged commit e9c1f74 into main Nov 9, 2023
@SirCipher SirCipher deleted the server-bindings branch November 9, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants