Skip to content
This repository has been archived by the owner on Mar 20, 2024. It is now read-only.

Breadcrumb, delete aria-selected and aria-label #596

Closed
bit-pro-iew-eui opened this issue Nov 17, 2017 · 1 comment
Closed

Breadcrumb, delete aria-selected and aria-label #596

bit-pro-iew-eui opened this issue Nov 17, 2017 · 1 comment
Assignees
@gillerr
Labels
accessibility
Milestone
3.2

Comments

@bit-pro-iew-eui
Copy link
Contributor

bit-pro-iew-eui commented Nov 17, 2017 •
edited
Loading

The aria tags in the breadcrumb causes that the screenreader announces "Current Page" instead of the last breadcrumb text.
Please delete the aria-selected and aria-label in the breadcrumb, as described here:

image

https://swiss.github.io/styleguide/de/hierarchical-navigation.html#01-hierarchical-navigation-02-breadcrumb
@bit-pro-iew-eui bit-pro-iew-eui added this to the Next milestone Nov 17, 2017
@gillerr gillerr assigned gillerr and unassigned vanquix Dec 5, 2017
gillerr added a commit that referenced this issue Dec 7, 2017
@gillerr
fix(breadcrumb): add release notes
8edfe78 
#595, #596
@gillerr gillerr closed this as completed Dec 7, 2017
@bit-pro-iew-eui bit-pro-iew-eui modified the milestones: 3.3, 3.2 Dec 7, 2017
@bit-pro-iew-eui
Copy link
Contributor Author

Ok, validated

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gillerr gillerr

Labels
accessibility
Projects
None yet
Milestone
3.2
Development

No branches or pull requests
3 participants
@gillerr @bit-pro-iew-eui @vanquix