This repository has been archived by the owner on Feb 7, 2019. It is now read-only.
Fix self-referencing many to many query #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the SelfReferencingManyToManyTest.test_relationship_spanning_query test to pass; it was previously raising an error.
|
The failed Travis check was due to me deleting a branch that I had pushed to the wrong repository. The successful Travis check is what was triggered by the pull request. In other words, it is safe to merge. |
|
Hey @brki, thanks for this fix! During review I was thinking about whether it would be a good idea to add a sentence or two describing the purpose of |
maennel
added a commit
that referenced
this pull request
Jan 6, 2016
Fix self-referencing many to many query
|
Thanks!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test and adapted code to make the test pass.
This fixes an issue with when querying a self-referencing many-to-many model in Django 1.6 and 1.7.
Django 1.8 was not affected by this problem.