This repository has been archived by the owner on Feb 7, 2019. It is now read-only.
Only use query_time when it has explicitly been set via as_of #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose that we change how query_time is handled.
Up until now, code like:
would print out "0", because when a1 was fetched, it's query_time was set to the time the fetch query was made. I think it should print out "1".
What I'm proposing, is that an object that is fetched via objects.current, or has had it's as_of time explicitly set to None, will reflect the ongoing current state, not the state at the time when the object was fetched.
I propose this for two reasons: