Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

[bug] #13 - Timeout::Error does not exists #14

Conversation

NetForces
Copy link
Contributor

closes #13

@coveralls
Copy link

coveralls commented Feb 12, 2018

Coverage Status

Coverage increased (+0.02%) to 89.28% when pulling 5fa1e6d on NetForces:bug-nf-13-timeout-error-does-not-exists into 9032f8b on swisscom:master.

@NetForces NetForces force-pushed the bug-nf-13-timeout-error-does-not-exists branch from e5437ed to 3c1caab Compare February 12, 2018 19:36
@HoneyryderChuck
Copy link
Collaborator

Thx for the PR. Unfortunately this is not the fix.

You should add :

require "timeout"

At the beginning of the file.

Could you open a new PR?

@NetForces NetForces force-pushed the bug-nf-13-timeout-error-does-not-exists branch from 47be70e to 217119d Compare February 12, 2018 19:59
@NetForces
Copy link
Contributor Author

Changed the fix. Works as expected on my test rig.

@HoneyryderChuck
Copy link
Collaborator

Can you do something about the ci errors? Rubocop is complaining ;)

@NetForces
Copy link
Contributor Author

NetForces commented Feb 13, 2018

Will try to address it this afternoon.

@HoneyryderChuck
Copy link
Collaborator

@NetForces any progress? For the record this should be fairly straightforward, just do rubocop -a and commit the changes.

@NetForces NetForces force-pushed the bug-nf-13-timeout-error-does-not-exists branch from 989e3ce to 5fa1e6d Compare February 15, 2018 12:30
@NetForces
Copy link
Contributor Author

@HoneyryderChuck all yours. Sorry for the delay.

@HoneyryderChuck HoneyryderChuck merged commit b664035 into swisscom:master Feb 15, 2018
@HoneyryderChuck
Copy link
Collaborator

thx again! will see about not delaying the release much further.

@HoneyryderChuck
Copy link
Collaborator

0.1.4 is out

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeout::Error does not exists
3 participants