Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create propertie guidelines #1669

Closed
wueestd opened this issue Jul 26, 2023 · 3 comments
Closed

create propertie guidelines #1669

wueestd opened this issue Jul 26, 2023 · 3 comments
Assignees
@wueestd
Labels
📦 documentation Related to the @swisspost/design-system-documentation package

Comments

@wueestd
Copy link

wueestd commented Jul 26, 2023 •
edited
Loading

In many components, we use different propertie names and values:

Image

Image

Image

Image

The aim of this task is to document those properties for the consistency within designers and also between designers and devs.
@wueestd wueestd added the 📦 documentation Related to the @swisspost/design-system-documentation package label Jul 26, 2023
@wueestd wueestd self-assigned this Jul 26, 2023
@wueestd
Copy link
Author

wueestd commented Sep 19, 2023

we discussed the properties here: https://www.figma.com/file/vaMVJ9REUj8EskXdH3beTj/Discussion-Board?type=whiteboard&node-id=117-470&t=KW0pIVlgyL9p0C5t-4

@wueestd
Copy link
Author

wueestd commented Sep 19, 2023 •
edited
Loading

descrpied a first draft here, have a look at it @rouvenpost and write some comments if you don't agree 👎 : https://www.figma.com/file/442uMtJtqZx4bATDtiQY9r/Onboarding?type=whiteboard&node-id=10-452&t=fuU8xI6y61YC8Fp0-4

else you can close the task

@wueestd wueestd assigned rouvenpost and unassigned wueestd Sep 20, 2023
@wueestd wueestd assigned wueestd and unassigned rouvenpost Nov 15, 2023
@wueestd wueestd closed this as completed Nov 15, 2023
@rouvenpost
Copy link

I would enhance the Breakpoints with Pixelsizes. For Example XL (>1920). Only XL can be open to interpretation and is not very helpful especially when you are new to the Designsystem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wueestd wueestd

Labels
📦 documentation Related to the @swisspost/design-system-documentation package
Projects
Design System Production Board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wueestd @rouvenpost