Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement common files support for merging #16

Closed
wants to merge 2 commits into from

Conversation

matthyx
Copy link
Collaborator

@matthyx matthyx commented Nov 14, 2017

No description provided.

@mryan43
Copy link
Member

mryan43 commented Nov 18, 2017

The implementation, changing the order of processing of override/merges based on the name of one module seems difficult to maintain and evolve in the future. And it's also not possible to have multiple jars providing "common" files.

I think we could implement this feature as a CarnotzetExtension. The extension could take ias parameter an ordered list of modules (which are not part of the carnotzet dependency tree) that contain "common" configuration overrides and merge files. The extension would then apply those override and merges in target/carnotzetresolved/...

What do you think ?

@matthyx
Copy link
Collaborator Author

matthyx commented Nov 20, 2017

Yes, that's a good idea... because I can see some catastrophic cases where a transient dependency could pollute all modules with just one common.
How should we proceed?

@mryan43
Copy link
Member

mryan43 commented Nov 20, 2017

Try to move the implementation of the feature in a separate CarnotzetExtension.

@matthyx matthyx closed this Nov 24, 2017
@matthyx matthyx deleted the issue-13 branch November 24, 2017 15:38
@matthyx matthyx restored the issue-13 branch August 16, 2018 14:15
@matthyx matthyx deleted the issue-13 branch August 16, 2018 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants