Skip to content

MouseInput functions #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 16, 2017
Merged

MouseInput functions #23

merged 7 commits into from
Mar 16, 2017

Conversation

supudo
Copy link

@supudo supudo commented Mar 5, 2017

Hey :)

Some of the mouse input functions here.

Cheers,
S.

@swistakm
Copy link
Member

If you rebase it on current master we will be able to see how our new testing and coverage setup works with pull requests.

@swistakm swistakm added this to the 0.0.1 - initial release milestone Mar 13, 2017
@supudo
Copy link
Author

supudo commented Mar 15, 2017

OK I officially made a mess now :)

I'll create new clean branches and PR's for the not yet merged PR's here.

S.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d39bfae on supudo:MouseInputs into ** on swistakm:master**.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 40.891% when pulling bc7f12f on supudo:MouseInputs into eeb616b on swistakm:master.

swistakm
swistakm reviewed Mar 16, 2017
View reviewed changes
Copy link
Member

@swistakm swistakm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two minor details to fix.

imgui/core.pyx Outdated
"""Return the mouse cursor id.
.. wraps::
void GetMouseCursor()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be:

ImGuiMouseCursor GetMouseCursor()

void will definitely confuse the reader.

imgui/core.pyx Outdated
return cimgui.GetMouseCursor()


def set_mouse_cursor(cimgui.ImGuiMouseCursor type):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type is a built-in function in Python. It would be better to use other name e.g. cursor/cursor_type or use the builtin_/keyword_ convention instead of plain builtin/keyword. It's up to you which one you will choose.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 40.891% when pulling 1e60d9d on supudo:MouseInputs into eeb616b on swistakm:master.

@swistakm swistakm merged commit bd9a99e into pyimgui:master Mar 16, 2017
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 78bc5c8 on supudo:MouseInputs into ** on swistakm:master**.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swistakm swistakm swistakm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.0.1 - initial release
Development

Successfully merging this pull request may close these issues.
3 participants
@supudo @swistakm @coveralls